Added support array attributes #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mujtaba-ahmed12
requested review from
Aneurysm9,
MrAlias,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
|
|
Member
|
Sorry, new CLA bot so you'll have to reauthorize. |
jmacd
reviewed
Jun 8, 2020
mujtaba-ahmed12
force-pushed
the
array_attributes
branch
from
28af88a to
52d3435
Compare
MrAlias
requested changes
Jun 15, 2020
Contributor
There was a problem hiding this comment.
Breaking slice types apart by underlying type doesn't seem like a good approach.
- Array values are no longer supported with this strategy.
- The smaller more unified old constructor functions from a previous commit seemed to more universally handle user arrays/attributes.
It seems like there might be benefit to having a "getter" functions that could return a typed slice. Though I'm not 100% sure they are needed at this point (most of these key-values are just encoded to attributes as strings) and I think they could be implemented in the previous approach if needed.
mujtaba-ahmed12
force-pushed
the
array_attributes
branch
from
52d3435 to
e2d0f2d
Compare
MrAlias
reviewed
Jun 22, 2020
Contributor
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
This is getting close. The only blocker is the question on on the AsArray function, otherwise minor things.
mujtaba-ahmed12
force-pushed
the
array_attributes
branch
from
9ce65e0 to
fcc12d3
Compare
MrAlias
approved these changes
Jun 23, 2020
Contributor
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
LGTM. Just comments need to be updated.
evantorrie
reviewed
Jun 23, 2020
evantorrie
reviewed
Jun 23, 2020
mujtaba-ahmed12
force-pushed
the
array_attributes
branch
from
fbcec9b to
1c2bfc9
Compare
jmacd
reviewed
Jun 24, 2020
jmacd
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.