Update Error Handling #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test handler
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
jmacd
approved these changes
Jun 2, 2020
Contributor
jmacd
left a comment
jmacd
left a comment
There was a problem hiding this comment.
Someday, someone will come along and ask why it's not possible to have per-SDK error callbacks. I propose we wait for that to happen. This is great.
Aneurysm9
reviewed
Jun 2, 2020
Member
I was thinking the same thing myself, also that I don't think it's possible to change the global handler once one is set. But, I can't point to a use case for that and it's definitely something that can be changed if needed down the road. |
Co-authored-by: Anthony Mirabella <[email protected]>
Aneurysm9
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global.Handlefunction.SetNamewhen span is uninitialized.Closes #174