-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add example that uses OTLP and the collector #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aneurysm9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that example/otlp/otel-test is added to .gitignore and force-push a commit history that does not include a 13MB build artifact.
My bad! Binary removed from commit history |
Sync the local branch with upstream changes
|
Thanks @wtong98, we just need one more thing from you since this is your first contribution, which is to provide a CLA. https://identity.linuxfoundation.org/projects/cncf Once you've done that, comment on this issue to let the bot pick up the change in status and it should be good to go. |
|
Great! All set with the CLA. Thanks again for all your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a large overlap here with the otel-collector example. Could these be merged?
Possibly in this PR, or a subsequent one?
Good idea! At the moment, this example was intended to be more of a light-weight demo of using otlp for trace and metric export, rather than a full-on pipeline from sdk to collector to backend. It definitely seems like a good idea to fold it into the otel-collector example, but would it be possible to relegate that work to a future PR? |
|
Captured request to merge in #795 |
Adds an example in which a simple application exports both trace and metric telemetry data using OTLP to a collector instance. This PR started as an intern exercise, and we figured you may like it as additional documentation.