Skip to content

Conversation

@wtong98
Copy link

@wtong98 wtong98 commented Jun 2, 2020

Adds an example in which a simple application exports both trace and metric telemetry data using OTLP to a collector instance. This PR started as an intern exercise, and we figured you may like it as additional documentation.

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that example/otlp/otel-test is added to .gitignore and force-push a commit history that does not include a 13MB build artifact.

@wtong98
Copy link
Author

wtong98 commented Jun 2, 2020

Please ensure that example/otlp/otel-test is added to .gitignore and force-push a commit history that does not include a 13MB build artifact.

My bad! Binary removed from commit history

@wtong98 wtong98 requested a review from Aneurysm9 June 2, 2020 19:16
wtong98 added 2 commits June 2, 2020 14:28
@wtong98 wtong98 requested a review from Aneurysm9 June 2, 2020 19:33
@Aneurysm9 Aneurysm9 added the blocked:CLA Waiting on CLA to be signed before progress can be made label Jun 2, 2020
@Aneurysm9
Copy link
Member

Thanks @wtong98, we just need one more thing from you since this is your first contribution, which is to provide a CLA. https://identity.linuxfoundation.org/projects/cncf Once you've done that, comment on this issue to let the bot pick up the change in status and it should be good to go.

@wtong98
Copy link
Author

wtong98 commented Jun 3, 2020

Great! All set with the CLA. Thanks again for all your help!

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a large overlap here with the otel-collector example. Could these be merged?

Possibly in this PR, or a subsequent one?

@Aneurysm9 Aneurysm9 removed the blocked:CLA Waiting on CLA to be signed before progress can be made label Jun 3, 2020
@wtong98
Copy link
Author

wtong98 commented Jun 3, 2020

There is a large overlap here with the otel-collector example. Could these be merged?

Possibly in this PR, or a subsequent one?

Good idea! At the moment, this example was intended to be more of a light-weight demo of using otlp for trace and metric export, rather than a full-on pipeline from sdk to collector to backend. It definitely seems like a good idea to fold it into the otel-collector example, but would it be possible to relegate that work to a future PR?

@MrAlias
Copy link
Contributor

MrAlias commented Jun 4, 2020

Captured request to merge in #795

@MrAlias MrAlias merged commit a43367a into open-telemetry:master Jun 4, 2020
@wtong98 wtong98 deleted the otlp-example branch June 4, 2020 20:01
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants