Add gRPC Default Service Config To OTLP Exporter #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add information about setup, options, and retries.
Needs to be run `GRPC_GO_RETRY=on go test .` to not fail the failing tests because retries are not enabled by default, nor can they be enabled programmatically.
The lack of programmatic enablement of retries means testing is going to be flaky or cumbersome.
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
Aneurysm9
approved these changes
May 30, 2020
jmacd
approved these changes
May 30, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
This does not include any testing for the added config. End-to-end testing of the retries is possible to write, but enabling the retries can only be done from the command line. This would mean that tests could not be successfully run without updating all test runs to include this var setting and having all developers set this var at test time. Furthermore, it doesn't seem necessary to test the end-to-end functionality of functionality from a dependency.
The gRPC library does not export its service config validation function either. This means the unique config syntax cannot be tested either. I imagine this will change as service configs become more mature, and we should add testing at that point.
Resolves #561