Skip to content

otlpmetrichttp otlptracehttp: Do not parse non-protobuf reponses#4719

Merged
pellared merged 4 commits into
open-telemetry:mainfrom
pellared:fix-4174
Nov 16, 2023
Merged

otlpmetrichttp otlptracehttp: Do not parse non-protobuf reponses#4719
pellared merged 4 commits into
open-telemetry:mainfrom
pellared:fix-4174

Conversation

@pellared

@pellared pellared commented Nov 15, 2023

Copy link
Copy Markdown
Member

Fixes #4717

@pellared
pellared marked this pull request as ready for review November 15, 2023 13:58
@codecov

codecov Bot commented Nov 15, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4719 (46d0335) into main (d968509) will decrease coverage by 0.1%.
The diff coverage is 61.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4719     +/-   ##
=======================================
- Coverage   81.8%   81.8%   -0.1%     
=======================================
  Files        224     224             
  Lines      18083   18113     +30     
=======================================
+ Hits       14796   14817     +21     
- Misses      2990    3000     +10     
+ Partials     297     296      -1
Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 80.8% <100.0%> (+0.3%) ⬆️
...pmetric/otlpmetrichttp/internal/otest/collector.go 56.7% <100.0%> (+2.0%) ⬆️
exporters/otlp/otlptrace/otlptracehttp/client.go 76.9% <100.0%> (+0.3%) ⬆️
...pmetric/otlpmetricgrpc/internal/otest/collector.go 21.8% <0.0%> (-1.1%) ⬇️

... and 1 file with indirect coverage changes

MrAlias
MrAlias reviewed Nov 15, 2023
View reviewed changes
Comment thread exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go Outdated
Comment thread exporters/otlp/otlpmetric/otlpmetricgrpc/internal/otest/collector.go Outdated
Comment thread exporters/otlp/otlpmetric/otlpmetrichttp/client.go
@pellared
pellared requested a review from MrAlias November 15, 2023 17:48
@dashpole dashpole added bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package labels Nov 16, 2023
@pellared
pellared merged commit 8ceba13 into open-telemetry:main Nov 16, 2023
@pellared
pellared deleted the fix-4174 branch November 16, 2023 17:38
@pellared pellared mentioned this pull request Nov 16, 2023
Merged
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashpole dashpole dashpole approved these changes
@MrAlias MrAlias MrAlias approved these changes
@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9
@evantorrie evantorrie Awaiting requested review from evantorrie
@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner
@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod
@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung
@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees

No one assigned

Labels

bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package

Projects

None yet

Milestone

untracked

Development

Successfully merging this pull request may close these issues.

otlpmetrichttp otlptracehttp: Handle non-protobuf responses

4 participants

@pellared @dashpole @MrAlias @XSAM