Move view example into prometheus example, and deprecate /example/view#4649
Merged
Conversation
dashpole
added
pkg:exporter:prometheus
dashpole
force-pushed
the
move_view_prometheus
branch
from
October 20, 2023 20:53
2e1fd85 to
d7f4769
Compare
dashpole
marked this pull request as ready for review
October 20, 2023 20:53
dashpole
requested review from
Aneurysm9,
MadVikingGod,
MrAlias,
XSAM,
dmathieu,
evantorrie,
hanyuancheung and
pellared
as code owners
October 20, 2023 20:53
MrAlias
approved these changes
Oct 20, 2023
MrAlias
left a comment
MrAlias
left a comment
Contributor
There was a problem hiding this comment.
LGTM outside of lint clean up
hanyuancheung
approved these changes
Oct 21, 2023
dmathieu
approved these changes
Oct 23, 2023
dashpole
force-pushed
the
move_view_prometheus
branch
from
October 23, 2023 13:03
a1710d0 to
41ee05f
Compare
pellared
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4509