Codecov Report

Merging #4362 (da596b0) into main (d5d6318) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4362   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files        184     184           
  Lines      14383   14383           
=====================================
+ Hits       12002   12004    +2     
+ Misses      2153    2151    -2     
  Partials     228     228           

@MrAlias

Have you given a look to upgrading all use of semconv in this repo and contrib to these changes? Are we missing any thing in the generation to accomplish this?

I have not found anything missing. Is there anything special that I should double-check?

Are you planning to upgrade semconv in follow PRs?

I created a separate issue #4364 to address this.

Is there anything special that I should double-check?

Nothing seems obvious to me in glancing over this, but I haven't tried the upgrade. I was just wondering given the shuffle upstream and the fact that we don't generate everything if we missed something.

If you've already taken a look at the upgrade that's good enough for me.

Hi,
Seems httpconv doesn't exist in v1.21.0, but it exists in v1.20.0, and It creates some incompatibility in our apps and for using httpconv features we have to add a reference to old v1.20.0 version beside of v1.21.0

Hi, Seems httpconv doesn't exist in v1.21.0, but it exists in v1.20.0, and It creates some incompatibility in our apps and for using httpconv features we have to add a reference to old v1.20.0 version beside of v1.21.0

Hi @mehdihadeli

See:

It was as designed and planned as part of #4081

If you want you can copy-paste (or generate the code like we do e.g. here) the code from https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/internal/shared/semconvutil

Can I use opentelemetry-go-contrib package and semconvutil and httpconv directly, instead of creating it manually myself? It is internal and it is not possible