[exporters/otlptracehttp] Do not log errors for 2XX response#3707
[exporters/otlptracehttp] Do not log errors for 2XX response#3707songy23 wants to merge 4 commits into
Conversation
|
cc @dineshg13 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3707 +/- ##
=====================================
Coverage 79.7% 79.7%
=====================================
Files 171 171
Lines 12673 12673
=====================================
Hits 10103 10103
Misses 2357 2357
Partials 213 213
|
Aneurysm9
left a comment
There was a problem hiding this comment.
Hoisting this as it was on a comment chain that got resolved:
On success, the server MUST respond with
HTTP 200 OK.
If the request is only partially accepted (i.e. when the server accepts only parts of the data and rejects the rest), the server MUST respond with
HTTP 200 OK.
Nothing other than a 200 OK response is according to spec.
The spec says cc @Aneurysm9 |
The OTel spec for OTLP/HTTP says that servers must respond to fully or partially successful requests with That other SDKs do something different doesn't mean that we need to follow their lead. |
|
@Aneurysm9 @songy23 I have created an issue on Spec . open-telemetry/opentelemetry-specification#3203 . It looks like we need a clarification on the spec for this issue. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This is already addressed |
Fixes #3706