add otlp trace http exporter#1963
Merged
MrAlias merged 5 commits intoopen-telemetry:mainfrom Jun 7, 2021
paivagustavo:otlp_trace_http_exporter
Merged
add otlp trace http exporter#1963MrAlias merged 5 commits intoopen-telemetry:mainfrom paivagustavo:otlp_trace_http_exporter
MrAlias merged 5 commits intoopen-telemetry:mainfrom
paivagustavo:otlp_trace_http_exporter
Conversation
paivagustavo
requested review from
Aneurysm9,
MadVikingGod,
MrAlias,
XSAM,
dashpole,
evantorrie and
jmacd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1963 +/- ##
=======================================
+ Coverage 76.3% 76.5% +0.2%
=======================================
Files 157 160 +3
Lines 8363 8495 +132
=======================================
+ Hits 6385 6505 +120
- Misses 1723 1732 +9
- Partials 255 258 +3
|
paivagustavo
commented
May 27, 2021
Aneurysm9
approved these changes
May 27, 2021
MadVikingGod
approved these changes
Jun 3, 2021
Contributor
MadVikingGod
left a comment
MadVikingGod
left a comment
There was a problem hiding this comment.
Other than the Exported constants I think this is good to go.
MrAlias
approved these changes
Jun 4, 2021
MrAlias
reviewed
Jun 6, 2021
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #1922.
This implements a HTTP
otlptrace.Client.Next steps
This is part of the #1827 todo list: