Skip to content

Add Status type to SDK#1874

Merged
MrAlias merged 8 commits intoopen-telemetry:mainfrom
MrAlias:sdk-status
May 3, 2021
Merged

Add Status type to SDK#1874
MrAlias merged 8 commits intoopen-telemetry:mainfrom
MrAlias:sdk-status

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented May 2, 2021

Instead of having two methods to return related information about the span status, use this new type to encapsulate the Span status similar to how the Event type encapsulates a Span event and the Link type encapsulates a span link.

Additionally, change the term status message to status description to match the language in the specification.

Part of the clean up included in #1873 for #1380.

MrAlias added 3 commits May 2, 2021 13:56
Use this type to encapsulate the Span status similar to the Event type
encapsulating a Span event and the Link type a span link.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2021

Codecov Report

Merging #1874 (4f28bd0) into main (f90d0d9) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1874   +/-   ##
=====================================
  Coverage   78.7%   78.7%           
=====================================
  Files        137     137           
  Lines       7343    7339    -4     
=====================================
- Hits        5784    5781    -3     
  Misses      1317    1317           
+ Partials     242     241    -1     
Impacted Files Coverage Δ
trace/trace.go 86.7% <ø> (ø)
exporters/otlp/internal/otlptest/data.go 87.7% <100.0%> (-0.3%) ⬇️
exporters/otlp/internal/transform/span.go 98.1% <100.0%> (ø)
exporters/trace/jaeger/jaeger.go 92.3% <100.0%> (-0.6%) ⬇️
exporters/trace/zipkin/model.go 99.1% <100.0%> (ø)
sdk/trace/span.go 93.9% <100.0%> (-0.1%) ⬇️
sdk/trace/batch_span_processor.go 87.1% <0.0%> (+1.5%) ⬆️

Comment thread CHANGELOG.md Outdated
Comment thread exporters/trace/zipkin/model_test.go Outdated
@MrAlias MrAlias merged commit b7d02db into open-telemetry:main May 3, 2021
@MrAlias MrAlias deleted the sdk-status branch May 3, 2021 19:01
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
MrAlias added a commit that referenced this pull request May 20, 2025
- Add the new metric API package structure prototyped in
https://github.com/MrAlias/semconv-go

  Prototypes of new metric API use:
   - MrAlias/opentelemetry-go-contrib#6136
   - MrAlias/opentelemetry-go-contrib#6135
   - MrAlias/opentelemetry-go-contrib#6134
- Generate `semconv/v1.32.0`
- Drop the `kestrel` metric namespace as this is a Java specific
technology

## [`v1.32.0` semantic convention release
notes](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.32.0):

<div data-pjax="true" data-test-selector="body-content"
data-view-component="true" class="markdown-body my-3"><p>📣 This release
is the second release candidate for the Database Semantic Conventions,
with <strong>db conventions stability planned to be declared in the
subsequent release</strong>.</p>
<h3>🛑 Breaking changes 🛑</h3>
<ul>
<li><code>device</code>: Change the definition of <code>device.id</code>
and make it opt-in. (<a
href="open-telemetry/semantic-conventions#1874"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1874/hovercard">#1874</a>,
<a
href="open-telemetry/semantic-conventions#1951"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1951/hovercard">#1951</a>)</li>
<li><code>feature_flag</code>: Rename <code>evaluation</code> to
<code>result</code> for feature flag evaluation result attributes (<a
href="open-telemetry/semantic-conventions#1989"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1989/hovercard">#1989</a>)</li>
</ul>
<h3>🚀 New components 🚀</h3>
<ul>
<li><code>app</code>: Create <code>app.installation.id</code> attribute
(<a
href="open-telemetry/semantic-conventions#1874"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1874/hovercard">#1874</a>,
<a
href="open-telemetry/semantic-conventions#1897"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1897/hovercard">#1897</a>)</li>
<li><code>cpython</code>: Add CPython runtime garbage collector metrics
(<a
href="open-telemetry/semantic-conventions#1930"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1930/hovercard">#1930</a>)</li>
</ul>
<h3>💡 Enhancements 💡</h3>
<ul>
<li><code>vcs</code>: Add owner and provider name to VCS attribute
registry (<a
href="open-telemetry/semantic-conventions#1452"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1452/hovercard">#1452</a>)</li>
<li><code>vcs</code>: Remove fallback value for VCS provider name
attribute (<a
href="open-telemetry/semantic-conventions#2020"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2020/hovercard">#2020</a>)</li>
<li><code>db</code>: Truncate <code>db.query.summary</code> to 255
characters if parsed from the query (<a
href="open-telemetry/semantic-conventions#1978"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1978/hovercard">#1978</a>)</li>
<li><code>db</code>: Normalize spaces in <code>db.operation.name</code>
(if any) (<a
href="open-telemetry/semantic-conventions#2028"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2028/hovercard">#2028</a>)</li>
<li><code>db</code>: <code>db.operation.parameter.&lt;key&gt;</code>
should not be captured for batch operations (<a
href="open-telemetry/semantic-conventions#2026"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2026/hovercard">#2026</a>)</li>
<li><code>db</code>: Add <code>db.stored_procedure.name</code> (<a
href="open-telemetry/semantic-conventions#1491"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1491/hovercard">#1491</a>)</li>
<li><code>gcp</code>: Adds GCP AppHub labels for resource. (<a
href="open-telemetry/semantic-conventions#2006"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2006/hovercard">#2006</a>)</li>
<li><code>error</code>: Add <code>error.message</code> property for
human-readable error message on events. (<a
href="open-telemetry/semantic-conventions#1992"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1992/hovercard">#1992</a>)</li>
<li><code>profile</code>: Extend the list of known frame types with a
value for Go and Rust (<a
href="open-telemetry/semantic-conventions#2003"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2003/hovercard">#2003</a>)</li>
<li><code>otel</code>: Adds SDK self-monitoring metrics for log
processing (<a
href="open-telemetry/semantic-conventions#1921"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1921/hovercard">#1921</a>)</li>
</ul>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants