drop failed to exporter batches and return error when forcing flush a span processor#1860
Merged
MrAlias merged 6 commits intoopen-telemetry:mainfrom Apr 29, 2021
paivagustavo:drop_failed_batches
Merged
drop failed to exporter batches and return error when forcing flush a span processor#1860MrAlias merged 6 commits intoopen-telemetry:mainfrom paivagustavo:drop_failed_batches
MrAlias merged 6 commits intoopen-telemetry:mainfrom
paivagustavo:drop_failed_batches
Conversation
paivagustavo
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie and
jmacd
as code owners
…o drop_failed_batches � Conflicts: � CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
=====================================
Coverage 78.6% 78.6%
=====================================
Files 137 137
Lines 7304 7305 +1
=====================================
+ Hits 5743 5749 +6
+ Misses 1316 1313 -3
+ Partials 245 243 -2
|
paivagustavo
added
release:1.0.0-rc.1
area:trace
Aneurysm9
approved these changes
Apr 28, 2021
Member
Aneurysm9
left a comment
Aneurysm9
left a comment
There was a problem hiding this comment.
It shouldn't matter with the batch being reset regardless of errors, but there's a line in processQueue() that should be updated. It's currently:
shouldExport := len(bsp.batch) == bsp.o.MaxExportBatchSizeand should probably be:
shouldExport := len(bsp.batch) >= bsp.o.MaxExportBatchSize
MrAlias
approved these changes
Apr 29, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a problem in the batch span processor and a nice-to-have error report on the
ForceFlush()method.Failed span batches are now dropped as expected. Quoting specs:
BatchSpanProcessor.ForceFlush()method now correctly report export errors. Quoting specs:Fixes #1833