Make timestamps sequential in lastvalue agg check #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
XSAM,
dashpole,
evantorrie,
jmacd and
lizthegrey
as code owners
Aneurysm9
approved these changes
Feb 24, 2021
The lastvalue timestamp is set on update. Correct the location of the sleep to bridge the update of the two different aggregators.
XSAM
approved these changes
Feb 25, 2021
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
* Make timestamps sequential in lastvalue agg check * Set PR number in changelog * Fix location of sleep The lastvalue timestamp is set on update. Correct the location of the sleep to bridge the update of the two different aggregators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1578