Pass metric labels when transforming to gaugeArray #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terev
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
=====================================
Coverage 77.6% 77.7%
=====================================
Files 128 128
Lines 6635 6637 +2
=====================================
+ Hits 5153 5157 +4
+ Misses 1235 1233 -2
Partials 247 247
|
Aneurysm9
approved these changes
Feb 23, 2021
MrAlias
approved these changes
Feb 24, 2021
Co-authored-by: Tyler Yahn <[email protected]>
XSAM
reviewed
Feb 25, 2021
Member
XSAM
left a comment
XSAM
left a comment
There was a problem hiding this comment.
Should we add a test to prevent regression?
Contributor
Author
|
I've added label requirements to the tests that call transforms |
jmacd
approved these changes
Feb 28, 2021
MrAlias
approved these changes
Feb 28, 2021
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
* Pass metric labels when transforming to gaugeArray * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Tyler Yahn <[email protected]> * Add label requirements to transformed metric assertions * Fix fmting Co-authored-by: Tyler Yahn <[email protected]>
This was referenced Mar 7, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1563
I dont know if there was any reasoning behind not passing these labels, but this change has fixed exporting of labels for me.