Add a case for respData.Len() == 0

pellared · pellared · commit 46d0335ea634 · 2023-11-15T19:41:20.000+01:00
diff --git a/exporters/otlp/otlpmetric/otlpmetrichttp/client.go b/exporters/otlp/otlpmetric/otlpmetrichttp/client.go
@@ -166,6 +166,10 @@ func (c *client) UploadMetrics(ctx context.Context, protoMetrics *metricpb.Resou
 			if _, err := io.Copy(&respData, resp.Body); err != nil {
 				return err
 			}
+			if respData.Len() == 0 {
+				return nil
+			}
+
 			if resp.Header.Get("Content-Type") == "application/x-protobuf" {
 				var respProto colmetricpb.ExportMetricsServiceResponse
 				if err := proto.Unmarshal(respData.Bytes(), &respProto); err != nil {
diff --git a/exporters/otlp/otlptrace/otlptracehttp/client.go b/exporters/otlp/otlptrace/otlptracehttp/client.go
@@ -177,6 +177,9 @@ func (d *client) UploadTraces(ctx context.Context, protoSpans []*tracepb.Resourc
 			if _, err := io.Copy(&respData, resp.Body); err != nil {
 				return err
 			}
+			if respData.Len() == 0 {
+				return nil
+			}
 
 			if resp.Header.Get("Content-Type") == "application/x-protobuf" {
 				var respProto coltracepb.ExportTraceServiceResponse

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,9 @@ func (d client) UploadTraces(ctx context.Context, protoSpans []tracepb.Resourc`
`177`	`177`	`if _, err := io.Copy(&respData, resp.Body); err != nil {`
`178`	`178`	`return err`
`179`	`179`	`}`
	`180`	`+ if respData.Len() == 0 {`
	`181`	`+ return nil`
	`182`	`+ }`
`180`	`183`
`181`	`184`	`if resp.Header.Get("Content-Type") == "application/x-protobuf" {`
`182`	`185`	`var respProto coltracepb.ExportTraceServiceResponse`