|
4 | 4 | package main |
5 | 5 |
|
6 | 6 | import ( |
| 7 | + "bytes" |
7 | 8 | "os" |
8 | 9 | "path/filepath" |
| 10 | + "strings" |
9 | 11 | "testing" |
10 | 12 | ) |
11 | 13 |
|
@@ -42,6 +44,45 @@ func errorType(err error) {} |
42 | 44 | } |
43 | 45 | } |
44 | 46 |
|
| 47 | +// TestNoInvalidObservableHistogramTypes asserts that the semconv code |
| 48 | +// generator never emits types containing "HistogramObservable" or |
| 49 | +// "ObservableObservable", which would indicate the histogram-exclusion |
| 50 | +// rule in metric.go.j2 was accidentally removed or bypassed. |
| 51 | +func TestNoInvalidObservableHistogramTypes(t *testing.T) { |
| 52 | + t.Parallel() |
| 53 | + |
| 54 | + semconvDir := filepath.Join("..", "..", "..", "semconv") |
| 55 | + |
| 56 | + forbidden := [][]byte{ |
| 57 | + []byte("HistogramObservable"), |
| 58 | + []byte("ObservableObservable"), |
| 59 | + } |
| 60 | + |
| 61 | + err := filepath.WalkDir(semconvDir, func(path string, d os.DirEntry, err error) error { |
| 62 | + if err != nil { |
| 63 | + return err |
| 64 | + } |
| 65 | + if d.IsDir() || filepath.Base(path) != "metric.go" || !strings.HasSuffix(filepath.Base(filepath.Dir(path)), "conv") { |
| 66 | + return nil |
| 67 | + } |
| 68 | + |
| 69 | + data, err := os.ReadFile(path) |
| 70 | + if err != nil { |
| 71 | + return err |
| 72 | + } |
| 73 | + |
| 74 | + for _, term := range forbidden { |
| 75 | + if bytes.Contains(data, term) { |
| 76 | + t.Errorf("%s: contains forbidden substring %q", path, term) |
| 77 | + } |
| 78 | + } |
| 79 | + return nil |
| 80 | + }) |
| 81 | + if err != nil { |
| 82 | + t.Fatalf("WalkDir(%q) error = %v", semconvDir, err) |
| 83 | + } |
| 84 | +} |
| 85 | + |
45 | 86 | func writeGoFile(t *testing.T, dir, pkg, src string) { |
46 | 87 | t.Helper() |
47 | 88 |
|
|
0 commit comments