Repository navigation
Add host.arch attribute to HostDetector and update tests - #3147
Merged
Merged
Conversation
Contributor
Author
|
/easycla |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
==========================================
+ Coverage 69.90% 70.03% +0.12%
==========================================
Files 439 429 -10
Lines 16919 16888 -31
==========================================
Hits 11827 11827
+ Misses 5092 5061 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kielek
reviewed
Sep 25, 2025
Kielek
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution. Please fix some issues I have found.
Contributor
Author
|
Hi @Kielek , thanks for the quick review. I've addressed your comments. I marked the easy ones as resolved and left the remainder open for further feedback. Thanks! |
This was referenced Dec 22, 2025
Closed
This was referenced Dec 30, 2025
Closed
This was referenced Jan 6, 2026
Closed
Closed
Closed
This was referenced Jan 13, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially implements #1516
Changes
Adds detection and reporting of the host architecture (host.arch) using
System.Runtime.InteropServices.RuntimeInformation.ProcessArchitecturein theHostDetector.The host.arch attribute is now included in the detected resource attributes on supported platforms. The README has been updated to document the new attribute, and unit tests have been enhanced to verify that host.arch is present and correctly set.
This improves observability by providing architecture information as part of the host resource metadata.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes