Skip to content

[otlp] Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter#6229

Merged
rajkumar-rangaraj merged 9 commits into
open-telemetry:mainfrom
rajkumar-rangaraj:rajrang/removeGrpc
Apr 8, 2025
Merged

[otlp] Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter#6229
rajkumar-rangaraj merged 9 commits into
open-telemetry:mainfrom
rajkumar-rangaraj:rajrang/removeGrpc

Conversation

@rajkumar-rangaraj

@rajkumar-rangaraj rajkumar-rangaraj commented Apr 3, 2025

Copy link
Copy Markdown
Member

Fixes #6209
Design discussion issue #

Changes

Please provide a brief description of the changes here.

  • Removed the use of Grpc.Core on legacy frameworks.
  • Updated default protocol to HttpProtobuf for .NET Framework and .NET Standard 2.0.
  • Added runtime NotSupportedException if OtlpExportProtocol.Grpc is configured with the default factory on unsupported targets.
  • Added tests to verify the exception is thrown when default factory is used, and not thrown when a custom factory is supplied.

Follow up

  • Readme update.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@rajkumar-rangaraj
rajkumar-rangaraj requested a review from a team as a code owner April 3, 2025 23:03
@github-actions github-actions Bot added the infra Infra work - CI/CD, code coverage, linters label Apr 3, 2025
@rajkumar-rangaraj rajkumar-rangaraj changed the title Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter [otlp] Remove Grpc.Core support for .NET Framework and .NET Standard 2.0 in OTLP exporter Apr 3, 2025
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package labels Apr 3, 2025
Copilot AI reviewed Apr 3, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • Directory.Packages.props: Language not supported
  • src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj: Language not supported

@codecov

codecov Bot commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (f183a6a) to head (e325670).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6229      +/-   ##
==========================================
- Coverage   86.20%   86.18%   -0.03%     
==========================================
  Files         259      258       -1     
  Lines       11854    11793      -61     
==========================================
- Hits        10219    10164      -55     
+ Misses       1635     1629       -6
Flag Coverage Δ
unittests-Project-Experimental 86.11% <100.00%> (+0.21%) ⬆️
unittests-Project-Stable 86.11% <100.00%> (-0.03%) ⬇️
unittests-Solution 86.10% <100.00%> (+0.24%) ⬆️
unittests-UnstableCoreLibraries-Experimental 85.87% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ol/Implementation/ExportClient/OtlpExportClient.cs 100.00% <ø> (ø)
....OpenTelemetryProtocol/OtlpExportProtocolParser.cs 100.00% <ø> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 99.09% <100.00%> (+<0.01%) ⬆️
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 98.94% <ø> (+3.45%) ⬆️
...lemetryProtocol/OtlpLogExporterHelperExtensions.cs 95.03% <100.00%> (+0.76%) ⬆️
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 96.66% <100.00%> (+0.15%) ⬆️
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 97.40% <100.00%> (+0.14%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Kielek
Kielek reviewed Apr 4, 2025
View reviewed changes
Comment thread Directory.Packages.props Outdated
alanwest
alanwest reviewed Apr 4, 2025
View reviewed changes
Comment thread src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
alanwest
alanwest approved these changes Apr 4, 2025
View reviewed changes

@alanwest alanwest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion of marking OtlpExportProtocol.Grpc obsolete for .NET Framwork/.NET Standard.

alanwest
alanwest reviewed Apr 4, 2025
View reviewed changes
Comment thread src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md Outdated
Kielek
Kielek reviewed Apr 8, 2025
View reviewed changes
Comment thread src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExportProtocol.cs Outdated
@rajkumar-rangaraj
rajkumar-rangaraj merged commit aa73ce3 into open-telemetry:main Apr 8, 2025
@rajkumar-rangaraj rajkumar-rangaraj mentioned this pull request Apr 29, 2025
Merged
@xiang17 xiang17 mentioned this pull request May 22, 2025
Closed
@romerod

romerod commented Jul 14, 2025

Copy link
Copy Markdown

It would be nice if the information could be added to the breaking change that the endpoint URL needs to be adapted as HttpProtoBuf expects the full Url (as mentioned here in the notes: https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol#otlpexporteroptions) for example: http://localhost:4318/v1/logs for logs.

This was referenced Jul 25, 2025
Closed
Closed
Closed
This was referenced Jul 13, 2026
Open
Open
Closed
Open
Open
Closed
Closed
Closed
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kielek Kielek Kielek left review comments
Copilot code review Copilot Copilot left review comments
@alanwest alanwest alanwest approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file infra Infra work - CI/CD, code coverage, linters pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[otlp] Remove Grpc.Core Deprecated Package Dependency from OTLP Exporter

5 participants

@rajkumar-rangaraj @romerod @alanwest @Kielek