Skip to content

Inconsistent SamplingDecision Names #1255

@ejsmith

Description

@ejsmith
  • NotRecord
  • Record
  • RecordAndSampled

Seems like we should pick between present tense or past tense and make it consistent. Either Recorded / RecordedAndSampled or Record / RecordAndSample.

NotRecord doesn't make sense. It's not correct English. Maybe just Skip or DontRecord. Personally I like just Skip better. It's already in an enum so it's always going to be qualified like SamplingDecision.Skip.

My vote:

  • SamplingDecision.Skip
  • SamplingDecision.Record
  • SamplingDecision.RecordAndSample

https://github.com/open-telemetry/opentelemetry-dotnet/blob/master/src/OpenTelemetry/Trace/SamplingDecision.cs

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions