Skip to content

reduce quoteservice spans#702

Merged
cartersocha merged 3 commits into
open-telemetry:mainfrom
brettmc:quoteservice-reduced-spans
Jan 20, 2023
Merged

reduce quoteservice spans#702
cartersocha merged 3 commits into
open-telemetry:mainfrom
brettmc:quoteservice-reduced-spans

Conversation

@brettmc

@brettmc brettmc commented Jan 19, 2023

Copy link
Copy Markdown
Contributor

Changes

Update slim auto-instrumentation to beta4, and remove psr-15 auto-instrumentation.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs folder

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Fixes: #659

slim autoinstrumentation beta4 was updated to work without psr15, which was responsible for most of the spans
@brettmc
brettmc requested a review from a team January 19, 2023 23:10
@cartersocha

Copy link
Copy Markdown
Contributor

From 14 spans to 3 spans. Nice!

@cartersocha cartersocha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks @brettmc

@cartersocha

Copy link
Copy Markdown
Contributor

Fix towards #659

@mviitane mviitane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@julianocosta89 julianocosta89 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@cartersocha
cartersocha merged commit a77c842 into open-telemetry:main Jan 20, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quote] - auto-instrumentation produces more span than expected since #644

4 participants