Use different base images for frauddetectionservice#691
Merged
cartersocha merged 7 commits intoJan 18, 2023
Merged
Conversation
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
mviitane
approved these changes
Jan 18, 2023
mviitane
left a comment
mviitane
left a comment
Member
There was a problem hiding this comment.
Looks like a win-win for both build time and image size.
$ docker compose build frauddetectionservice --no-cache
Build time: 70.9s -> 54.9s
Image size: 509MB -> 271MB
Member
Author
|
Maybe to add this as a note: it looks like that python3.10 builds faster overall than python3.11 because of the availability of certain "wheels": if I go for 3.11 it starts to compile a bunch of things while for 3.10 it looks like they can easily be downloaded, maybe something that can also help with other python services. |
julianocosta89
approved these changes
Jan 18, 2023
mic-max
approved these changes
Jan 18, 2023
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* Use different docker base images for frauddetection service Signed-off-by: svrnm <[email protected]> * Add entry in CHANGELOG Signed-off-by: svrnm <[email protected]> * update changelog Signed-off-by: svrnm <[email protected]> * Remove extra blank line Signed-off-by: svrnm <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Carter Socha <[email protected]>
mohamed3637
added a commit
to mohamed3637/opentelemetry-demo
that referenced
this pull request
Oct 7, 2025
* Use different docker base images for frauddetection service Signed-off-by: svrnm <[email protected]> * Add entry in CHANGELOG Signed-off-by: svrnm <[email protected]> * update changelog Signed-off-by: svrnm <[email protected]> * Remove extra blank line Signed-off-by: svrnm <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Carter Socha <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the base images used for building & running frauddetectionservice:
builderit uses the gradle image, so downloading gradle is not necessary anymore since it is part of the image. This improves the build time a little bit (for me from ~70s to 60s), especially when doing repeated buildsMerge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions