Add resource detectors to cart service#663
Conversation
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Tried it out locally and nothing was added to the Resource Attributes. I suspect this is not working on my Ubuntu, because a similar issue happened when testing #662
|
Is it any specific version of docker required to this to work? |
julianocosta89
left a comment
There was a problem hiding this comment.
Tested in my Windows and it worked.
Also using docker
|
Doesn't work for me when using docker desktop on mac. |
|
This is probably due to a Limitation because of cgroup v2, there is a solution in the making for dotnet: open-telemetry/opentelemetry-dotnet-contrib#839 Java & NodeJS have that fixed already. |
|
Thanks @svrnm. Lgtm and the dependency PR seems to be making progress. Merging. |
Changes
Resource detection for cart service, right now it is only the container.id because it looks like no other resource detectors exist for .NET (yet)
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions