Add healthcheck to featureflagservice#661
Conversation
In order to assess the health of this central service, compose should perform a check on the service.
|
I believe we have decided on monitoring the health using Kubernetes and on not supporting doing through docker like your proposal. |
|
Why is that? If a certain service fails in the docker compose scenario, how do you know (other than fallout)? Does that mean the primary intention of this project is to be run on k8s? Then we should probably remove the docker compose file. |
julianocosta89
left a comment
julianocosta89
left a comment
There was a problem hiding this comment.
I personally like the addition.
There is a discussion going on that may change this though.
@cedricziel please feel free to add your insights in here: #635
|
@julianocosta89 thanks for raising awareness! |
puckpuck
added
the
helm-update-required
|
@puckpuck should we do something regarding helm in this one? |
|
We don't need to touch Helm for this. |
* Add healthcheck to featureflagservice In order to assess the health of this central service, compose should perform a check on the service. * Add changelog entry Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Carter Socha <[email protected]>
* Add healthcheck to featureflagservice In order to assess the health of this central service, compose should perform a check on the service. * Add changelog entry Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Carter Socha <[email protected]>
6 participants
Changes
In order to assess the health of this central service, compose should perform a check on the service.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.