Skip to content

[loadgenerator] - rewrite for new frontend and feature flags#290

Merged
puckpuck merged 7 commits into
open-telemetry:mainfrom
honeycombio:loadgen-rewrite
Aug 16, 2022
Merged

[loadgenerator] - rewrite for new frontend and feature flags#290
puckpuck merged 7 commits into
open-telemetry:mainfrom
honeycombio:loadgen-rewrite

Conversation

@puckpuck

@puckpuck puckpuck commented Aug 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

A major rewrite of the load generator to incorporate 3 big changes

  1. Work with the update routes defined by the frontend service rewrite
  2. Add multiple random "people" to the checkout call, to work with a future feature flag
  3. Update to use locust test suite @task annotations

The recently updated frontend service meant some changes to the load generator. Namely, there is no more set_currency load since that route no longer exists. The cart and checkout loads were updated to match what the new frontend service has in place.

  • Appropriate CHANGELOG.md updated for non-trivial changes

@puckpuck
puckpuck requested a review from a team August 11, 2022 03:08
@mviitane

mviitane commented Aug 12, 2022

Copy link
Copy Markdown
Member

Suggesting an update for the commit message:
"A major rewrite of the frontend service"
->
"A major rewrite of the load generator"

@mviitane

mviitane commented Aug 12, 2022

Copy link
Copy Markdown
Member

When running the updated loadgen, I can see the following in the log:

cart-service             | AddItemAsync called with userId=199d832e-1a2a-11ed-8863-0242c0a80013, productId=OLJCESPC7Z, quantity=1
cart-service             | GetCartAsync called with userId=199d832e-1a2a-11ed-8863-0242c0a80013
checkout-service         | {"message":"[PlaceOrder] user_id=\"199d832e-1a2a-11ed-8863-0242c0a80013\" user_currency=\"USD\"","severity":"info","timestamp":"2022-08-12T10:32:43.922355684Z"}
cart-service             | GetCartAsync called with userId=199d832e-1a2a-11ed-8863-0242c0a80013
frontend                 | Error: 13 INTERNAL: failed to prepare order: failed to convert price of "OLJCESPC7Z" to USD
frontend                 |     at Object.callErrorFromStatus (/app/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
frontend                 |     at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client.js:189:52)
frontend                 |     at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:365:141)
frontend                 |     at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:328:181)
frontend                 |     at /app/node_modules/@grpc/grpc-js/build/src/call-stream.js:187:78
frontend                 |     at processTicksAndRejections (node:internal/process/task_queues:78:11) {
frontend                 |   code: 13,
frontend                 |   details: 'failed to prepare order: failed to convert price of "OLJCESPC7Z" to USD',
frontend                 |   metadata: Metadata {
frontend                 |     internalRepr: Map(1) { 'content-type' => [Array] },
frontend                 |     options: {}
frontend                 |   }
frontend                 | }

@mviitane

mviitane commented Aug 15, 2022

Copy link
Copy Markdown
Member

When running the updated loadgen, I can see the following in the log:

After building with --no-cache option the error is gone. Loadgen seems to be running fine now.

@GaryPWhite

GaryPWhite commented Aug 15, 2022

Copy link
Copy Markdown
Contributor

confirmed -- this seems to work well for me too!

@cartersocha

cartersocha commented Aug 15, 2022

Copy link
Copy Markdown
Contributor

@puckpuck update (🙄) & merge at your leisure 🏎

@jorgeepc

jorgeepc commented Aug 15, 2022

Copy link
Copy Markdown
Contributor

Working well here too 👍

@puckpuck
puckpuck merged commit aac1bfb into open-telemetry:main Aug 16, 2022
@puckpuck
puckpuck deleted the loadgen-rewrite branch August 16, 2022 02:17
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck
[loadgenerator] - rewrite for new frontend and feature flags (open-te…
2c417c5 
…lemetry#290)

* loadgenerator rewrite

* remove set_currency from load generator

* add multi item checkout
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
@mohamed3637
[loadgenerator] - rewrite for new frontend and feature flags (open-te…
778f074 
…lemetry#290)

* loadgenerator rewrite

* remove set_currency from load generator

* add multi item checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@mic-max mic-max mic-max approved these changes
@mviitane mviitane mviitane approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@puckpuck @mviitane @GaryPWhite @cartersocha @jorgeepc @mic-max