[adservice] - add manual tracing instrumentation#150
Merged
cartersocha merged 5 commits intoJun 30, 2022
Merged
Conversation
julianocosta89
approved these changes
Jun 17, 2022
julianocosta89
left a comment
julianocosta89
left a comment
Member
There was a problem hiding this comment.
LGTM!
I've also deployed locally to ensure everything was compiling and working properly!
🚀 it!
austinlparker
previously requested changes
Jun 17, 2022
austinlparker
left a comment
austinlparker
left a comment
Member
There was a problem hiding this comment.
Overall lgtm, but I had some questions.
wph95
approved these changes
Jun 17, 2022
wph95
left a comment
wph95
left a comment
Member
There was a problem hiding this comment.
just help authoer to fix PR describe todolist format
wrong
[x] xxxxx
- [x] xxx
mic-max
approved these changes
Jun 21, 2022
Contributor
|
@austinlparker, @mic-max any comments to Pierre's responses ? |
Contributor
|
@puckpuck please update the branch & we can merge |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
mohamed3637
added a commit
to mohamed3637/opentelemetry-demo
that referenced
this pull request
Oct 7, 2025
osullivandonal
pushed a commit
to osullivandonal/opentelemetry-demo
that referenced
this pull request
Feb 25, 2026
Update from upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
Changes
Uses a mixture of adding spans and attributes using annotations, as well as manual creation of spans.
Attributes are added to existing auto-instrumented spans and newly created manual ones.