Skip to content

[paymentservice] [checkoutservice] introduce new featureflags - #1449

Merged
julianocosta89 merged 8 commits into
open-telemetry:mainfrom
EislM0203:paymentservice-checkoutservice-introduce-new-featureflags
Mar 14, 2024
Merged

[paymentservice] [checkoutservice] introduce new featureflags#1449
julianocosta89 merged 8 commits into
open-telemetry:mainfrom
EislM0203:paymentservice-checkoutservice-introduce-new-featureflags

Conversation

@EislM0203

@EislM0203 EislM0203 commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

This PR is an updated version of #1383 to conform to the updated feature flags. Also a comment regarding the paymentServiceUnreachable feature flag was addressed by moving the feature flag to the checkout-service.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@EislM0203 EislM0203 mentioned this pull request Mar 12, 2024
Merged
@EislM0203

EislM0203 commented Mar 12, 2024

Copy link
Copy Markdown
Contributor Author

Hello, as stated above this PR is the updated version of #1383. Sadly it seems like the helm chart is still outdated and I do not see any open PRs addressing that. Can you tell me what the status is there?

@EislM0203
EislM0203 marked this pull request as ready for review March 12, 2024 13:52
@EislM0203
EislM0203 requested a review from a team March 12, 2024 13:52
@julianocosta89

julianocosta89 commented Mar 13, 2024

Copy link
Copy Markdown
Member

Hello, as stated above this PR is the updated version of #1383. Sadly it seems like the helm chart is still outdated and I do not see any open PRs addressing that. Can you tell me what the status is there?

Excelent question!
I'll take a look into it.

@julianocosta89

julianocosta89 commented Mar 13, 2024

Copy link
Copy Markdown
Member

Hello, as stated above this PR is the updated version of #1383. Sadly it seems like the helm chart is still outdated and I do not see any open PRs addressing that. Can you tell me what the status is there?

There you go: open-telemetry/opentelemetry-helm-charts#1082

@EislM0203

EislM0203 commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

There you go: open-telemetry/opentelemetry-helm-charts#1082

@julianocosta89, thanks a lot for the info, as soon as this PR is merged I will make the changes to the helm chart.

Also, do you perchance know why the tracetesting check is failing? I am asking because I made sure to check that it passes locally (see image). Would appreciate your insights.
Screenshot 2024-03-14 at 08 58 25

@julianocosta89

julianocosta89 commented Mar 14, 2024

Copy link
Copy Markdown
Member

Also, do you perchance know why the tracetesting check is failing? I am asking because I made sure to check that it passes locally (see image). Would appreciate your insights.

Testing out your PR, I did see the failing test.
It seems that the folks from TraceTest changed the name of the trigger and the test wasn't found.
Not related to your PR, but since the update of traceTest you are the first one to touch checkoutService.

I added the fix to your PR, hope you don't mind.

@julianocosta89
julianocosta89 merged commit 8de7041 into open-telemetry:main Mar 14, 2024
@julianocosta89 julianocosta89 mentioned this pull request Mar 14, 2024
Merged
@EislM0203
EislM0203 deleted the paymentservice-checkoutservice-introduce-new-featureflags branch March 15, 2024 06:17
neamulkabiremon pushed a commit to neamulkabiremon/ultimate-devops-project-demo that referenced this pull request Apr 16, 2025
@EislM0203 @austinlparker @julianocosta89
[paymentservice] [checkoutservice] introduce new featureflags (open-t…
db8e6af 
…elemetry#1449)

* [paymentservice][checkoutservice] add paymentServiceFailure & paymentServiceUnreachable featureflags

* [checkoutservice] remove unnecessary log

* update changelog

* Fix trace test

---------

Co-authored-by: Austin Parker <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
mohamed3637 added a commit to mohamed3637/opentelemetry-demo that referenced this pull request Oct 7, 2025
@mohamed3637 @austinlparker @julianocosta89
[paymentservice] [checkoutservice] introduce new featureflags (open-t…
ccab531 
…elemetry#1449)

* [paymentservice][checkoutservice] add paymentServiceFailure & paymentServiceUnreachable featureflags

* [checkoutservice] remove unnecessary log

* update changelog

* Fix trace test

---------

Co-authored-by: Austin Parker <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austinlparker austinlparker austinlparker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EislM0203 @julianocosta89 @austinlparker