-
Notifications
You must be signed in to change notification settings - Fork 513
Build farm for Windows #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lookup itself using relative paths
…PI with Abseil Variant, but without entire Abseil Library
…s explicitly be defined, no implicit conversion to string_view)
…es not clash with gRPC Abseil
…r from std::string
…en both `std::` and `absl::` work differently!
…cts that do not link to opentelemetry_api target
maxgolov
commented
Jun 11, 2021
Contributor
Author
|
@lalitb @ThomsonTan - this PR is only dev build scripts necessary for all versions of Visual Studio. If you can have a quick look and merge, that'd be great! |
lalitb
approved these changes
Jul 8, 2021
ThomsonTan
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr:please-merge
This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
CMake+ninjabuild farm setup for the most common compilers used on modern versions of Windows.Both - developer -focused and CI/CD pipeline -focused, to cover the following compilers:
C++11/C++14- targeting Windows 8.1 SDK and above.C++17- targeting Windows 10 and above.C++20- targeting Windows 10 and above.Using the following build systems:
CMakeNinja- fastest, with optional fallback to MSBuild.vcpkg- used for dependency management.The process is largely documented here . Except that now we also support not only 2019. But older compilers too, plus LLVM Clang which we never had in our build system for Windows. Ad-hoc tested that the code works well with Clang-11 and Clang-12. This comes in handy, because things like Chromium on Windows - build with clang.
Build scripts contain enough comments for further customization and tweaking as-necessary. Someone implementing their own custom build pipeline may use these scripts as a reference example. Devs may also use these scripts to quickly build and test the SDK side-by-side with a set of different compilers installed on one box. Output from the build is laid out as follows:
Running something like:
Produces a set of build artifacts in one run:
nostdclasses - for ABI compat across different compilers.WITH_STL- for static linking, with native STL classes.for all compilers above.
Note that
vcpkginstallation for Visual Studio 2015 must always be stored separately from the rest. Because if you usevs2019to compile and linkvcpkglibraries -- these packages won't link to SDK being built withvs2015compiler and linker. That limitation described in Visual Studio compiler documentation here :