Skip to content

Refactor/duplicate enums #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lalitb merged 5 commits into from
Apr 9, 2021
Merged

Refactor/duplicate enums #658

lalitb merged 5 commits into from
Apr 9, 2021

Conversation

@anshulkumar19
Copy link
Contributor

@anshulkumar19 anshulkumar19 commented Apr 6, 2021

Fixes #420

Changes

  • Refactoring to put ExportResult enum class into sdk/common
  • Reusing this class to remove duplication

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@anshulkumar19 anshulkumar19 requested a review from a team April 6, 2021 08:41
@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Merging #658 (46f02c9) into main (7a0745d) will decrease coverage by 0.00%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   94.66%   94.65%   -0.01%     
==========================================
  Files         204      204              
  Lines        9384     9387       +3     
==========================================
+ Hits         8883     8885       +2     
- Misses        501      502       +1
Impacted Files Coverage Δ
...opentelemetry/exporters/ostream/metrics_exporter.h 98.64% <ø> (ø)
...de/opentelemetry/exporters/ostream/span_exporter.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/logs/exporter.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/metrics/exporter.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/metrics/meter.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/trace/exporter.h 100.00% <ø> (ø)
sdk/test/logs/batch_log_processor_test.cc 100.00% <ø> (ø)
sdk/test/logs/simple_log_processor_test.cc 92.45% <ø> (ø)
sdk/test/trace/simple_processor_test.cc 85.71% <ø> (ø)
...clude/opentelemetry/sdk/metrics/sync_instruments.h 93.84% <62.50%> (-0.69%) ⬇️
... and 10 more

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 6, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@anshulkumar19 anshulkumar19 reopened this Apr 8, 2021
lalitb
lalitb approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@lalitb lalitb merged commit 9a99b97 into open-telemetry:main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsuereth jsuereth jsuereth approved these changes

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove duplicate enum declarations

3 participants

@anshulkumar19 @jsuereth @lalitb