Skip to content

Updating PR Guidelines #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lalitb merged 4 commits into from
Dec 3, 2020
Merged

Updating PR Guidelines #413

lalitb merged 4 commits into from
Dec 3, 2020

Conversation

@lalitb
Copy link
Member

@lalitb lalitb commented Dec 2, 2020

Trying to update existing PR guidelines to ensure smoother ( and probably faster ) merge process:

  • With current small number of Approvers ( and their distribution across different companies ), making number of required approvals ( from different company ) as 1 ( from existing 2 ). We can review this after course of time once we have good distribution.
  • Requirement for Updating the changelog (CHANGELOG.md) for non-trivial changes.
  • Handling lots of discussions in given PR.

@lalitb lalitb requested a review from a team December 2, 2020 16:31
ThomsonTan
ThomsonTan reviewed Dec 2, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Dec 2, 2020 •
edited
Loading

Codecov Report

Merging #413 (cad6811) into master (26dbde3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         175      175           
  Lines        7591     7591           
=======================================
  Hits         7194     7194           
  Misses        397      397

jsuereth
jsuereth requested changes Dec 2, 2020
View reviewed changes
@lalitb lalitb merged commit 036fc7f into master Dec 3, 2020
@reyang reyang deleted the pr-merge branch January 20, 2021 23:22
@loong-hy loong-hy mentioned this pull request Sep 5, 2024
Merged
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Aug 31, 2025
@malkia
Merge pull request open-telemetry#413 from open-telemetry/main
ceb2876 
[CONFIGURATION] File configuration - component registry (open-telemetry#3537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsuereth jsuereth jsuereth approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lalitb @jsuereth @ThomsonTan