[SDK] Reset TraceFlags::IsSampled bit on sampler Decision::DROP #3745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3745 +/- ##
==========================================
+ Coverage 89.91% 89.91% +0.01%
==========================================
Files 225 225
Lines 7134 7135 +1
==========================================
+ Hits 6414 6415 +1
Misses 720 720
🚀 New features to boost your workflow:
|
dbarker
reviewed
Nov 16, 2025
|
|
||
| TEST(Tracer, SpanSamplerDecision) | ||
| { | ||
| InMemorySpanExporter *exporter = new InMemorySpanExporter(); |
Member
There was a problem hiding this comment.
nit - prefer make_unique/make_shared in place of new.
dbarker
approved these changes
Nov 16, 2025
Member
dbarker
left a comment
dbarker
left a comment
There was a problem hiding this comment.
Looks good. Thanks! Minor nitpick on new -> make_unique/make_shared.
ThomsonTan
approved these changes
Nov 17, 2025
ThomsonTan
approved these changes
Nov 17, 2025
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Nov 17, 2025
[SDK] Reset TraceFlags::IsSampled bit on sampler Decision::DROP (open-telemetry#3745)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3725
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes