-
Notifications
You must be signed in to change notification settings - Fork 512
[CONFIGURATION] File configuration - prometheus translation #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONFIGURATION] File configuration - prometheus translation #3715
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3715 +/- ##
==========================================
- Coverage 90.00% 89.92% -0.07%
==========================================
Files 225 225
Lines 7103 7103
==========================================
- Hits 6392 6387 -5
- Misses 711 716 +5 🚀 New features to boost your workflow:
|
functional/configuration/shelltests/prometheus_translation_1.test
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks. Minor comment to clarify the intent of the new shell tests. Consider renaming the files or adding comments.
Contributes to #2481
Implement prometheus translation strategy, per schema change:
Changes
Please provide a brief description of the changes here.
translation_strategyattribute.with_resource_constant_labelsattribute.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes