Skip to content

Conversation

@marcalff
Copy link
Member

Contributes to #2481

Implement prometheus translation strategy, per schema change:

Changes

Please provide a brief description of the changes here.

  • Implement prometheus translation_strategy attribute.
  • Implement missing prometheus with_resource_constant_labels attribute.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner October 25, 2025 22:36
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.92%. Comparing base (227fbdc) to head (01fc114).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3715      +/-   ##
==========================================
- Coverage   90.00%   89.92%   -0.07%     
==========================================
  Files         225      225              
  Lines        7103     7103              
==========================================
- Hits         6392     6387       -5     
- Misses        711      716       +5     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff added the pr:please-review This PR is ready for review label Oct 26, 2025
Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Minor comment to clarify the intent of the new shell tests. Consider renaming the files or adding comments.

@marcalff marcalff merged commit 3efc14b into open-telemetry:main Oct 27, 2025
67 checks passed
owent pushed a commit to owent/opentelemetry-cpp that referenced this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants