Skip to content

[CMAKE] Add CMake script to find or fetch prometheus-cpp #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 3 commits into from
Jul 9, 2025
Merged

[CMAKE] Add CMake script to find or fetch prometheus-cpp #3522

marcalff merged 3 commits into from
Jul 9, 2025

Conversation

@dbarker
Copy link
Member

@dbarker dbarker commented Jul 7, 2025

Fixes # (issue)

Changes

  • Adds CMake script to find or fetch prometheus-cpp
  • Explicitly link to the core and pull targets from the prometheus exporter.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify
Copy link

netlify bot commented Jul 7, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 7845429
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/686e2af45267e5000822c71e

@codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (a1e6011) to head (7845429).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         219      219           
  Lines        7051     7051           
=======================================
  Hits         6343     6343           
  Misses        708      708
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review July 7, 2025 18:41
@dbarker dbarker requested a review from a team as a code owner July 7, 2025 18:41
owent
owent reviewed Jul 8, 2025
View reviewed changes
owent
owent approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcalff
marcalff approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff merged commit 1ad6674 into open-telemetry:main Jul 9, 2025
70 checks passed
@dbarker dbarker deleted the cmake_find_or_fetch_prometheus_cpp branch July 10, 2025 16:43
@BrewTestBot BrewTestBot mentioned this pull request Jul 11, 2025
Merged
@dbarker dbarker mentioned this pull request Jul 16, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owent owent owent approved these changes

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarker @owent @marcalff