[SEMANTIC CONVENTIONS] Fix comment style to preserve markup #3444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
marcalff
changed the title
marcalff
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3444 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 212 212
Lines 6941 6941
=======================================
Hits 6238 6238
Misses 703 703 🚀 New features to boost your workflow:
|
This was referenced May 19, 2025
psx95
approved these changes
May 28, 2025
Contributor
psx95
left a comment
psx95
left a comment
There was a problem hiding this comment.
LGTM.
Went through the modified files and the changes match the PR description.
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
May 28, 2025
[SEMANTIC CONVENTIONS] Fix comment style to preserve markup (open-telemetry#3444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
Fixed the C++ comment style for generated code in semantic conventions (file
weaver.yaml).Before:
After:
This preserve the text markup, when it contains embedded doxygen or html content.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes