Skip to content

[EXPORTER] fix throw in OtlpGrpcMetricExporter with shared grpc client #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 2 commits into from
Jan 13, 2025
Merged

[EXPORTER] fix throw in OtlpGrpcMetricExporter with shared grpc client #3243

marcalff merged 2 commits into from
Jan 13, 2025

Conversation

@dbarker
Copy link
Member

@dbarker dbarker commented Jan 13, 2025 •
edited
Loading

Fixes #3242

OtlpGrpcMetricExporter throws on export when constructed with a shared grpc client.

Changes

  • Sets the OtlpGrpcMetricExporter::aggregation_temporality_selector_ in the constructors that accept a shared grpc client
  • Adds test cases to cover OtlpGrpcMetricExporter::GetAggregationTemporality

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker requested a review from a team as a code owner January 13, 2025 04:04
@netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit d321ae1
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/678491d2e4506b0008e3be3c

@codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (57114c5) to head (d321ae1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3243   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         198      198           
  Lines        6224     6224           
=======================================
  Hits         5487     5487           
  Misses        737      737

lalitb
lalitb approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

owent
owent approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

marcalff
marcalff approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 0b712dd into open-telemetry:main Jan 13, 2025
57 checks passed
@dbarker dbarker deleted the fix_aggregation_temporality_throw branch January 16, 2025 15:26
@BrewTestBot BrewTestBot mentioned this pull request Jan 22, 2025
Merged
@dbarker dbarker mentioned this pull request Mar 26, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

@owent owent owent approved these changes

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OtlpGrpcMetricExporter::GetAggregationTemporality throws when the exporter is constructed with a shared grpc client

4 participants

@dbarker @lalitb @owent @marcalff