Skip to content

[CI] Build failures with ABSEIL 20240116 and CMAKE 3.30 #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 5 commits into from
Jul 12, 2024
Merged

[CI] Build failures with ABSEIL 20240116 and CMAKE 3.30 #3002

marcalff merged 5 commits into from
Jul 12, 2024

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Jul 11, 2024 •
edited
Loading

Fixes #2998

Changes

Please provide a brief description of the changes here.

  • Backported a fix for abseil issue 1536, applied to abseil-cpp 20240116
  • Fixed the CI format to ignore *.patch files

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff changed the title [CI] FIX BUILD FAILURES WITH ABSEIL AND CMAKE 3.30 [CI] FIX BUILD FAILURES WITH ABSEIL 20240116 AND CMAKE 3.30 Jul 11, 2024
@marcalff marcalff changed the title [CI] FIX BUILD FAILURES WITH ABSEIL 20240116 AND CMAKE 3.30 [CI] BUILD FAILURES WITH ABSEIL 20240116 AND CMAKE 3.30 Jul 11, 2024
@codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (497eaf4) to head (6a908d6).
Report is 99 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
+ Coverage   87.12%   87.67%   +0.55%     
==========================================
  Files         200      190      -10     
  Lines        6109     5853     -256     
==========================================
- Hits         5322     5131     -191     
+ Misses        787      722      -65

see 120 files with indirect coverage changes

@marcalff marcalff changed the title [CI] BUILD FAILURES WITH ABSEIL 20240116 AND CMAKE 3.30 [CI] Build failures with ABSEIL 20240116 and CMAKE 3.30 Jul 11, 2024
@marcalff marcalff added issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review labels Jul 11, 2024
@marcalff marcalff marked this pull request as ready for review July 11, 2024 22:46
@marcalff marcalff requested a review from a team July 11, 2024 22:46
ThomsonTan
ThomsonTan reviewed Jul 12, 2024
View reviewed changes
@marcalff marcalff merged commit 63fa4fd into open-telemetry:main Jul 12, 2024
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jul 12, 2024
@malkia
Merge pull request #57 from open-telemetry/main
d7d53d2 
[CI] Build failures with ABSEIL 20240116 and CMAKE 3.30 (open-telemetry#3002)
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2024
Merged
@marcalff marcalff mentioned this pull request Aug 8, 2024
Merged
@marcalff marcalff deleted the fix_broken_abseil_ci branch February 5, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] Build failures with ABSEIL 20240116 and CMAKE 3.30

3 participants

@marcalff @ThomsonTan @lalitb