Skip to content

[SEMANTIC CONVENTIONS] Upgrade to version 1.26.0 #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 1 commit into from
May 31, 2024
Merged

[SEMANTIC CONVENTIONS] Upgrade to version 1.26.0 #2687

marcalff merged 1 commit into from
May 31, 2024

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented May 30, 2024 •
edited
Loading

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Upgraded to semantic conventions release v1.26.0
  • Implemented a workaround for a C++ name collision:
    • deprecated semconv messaging.client_id is generated as kMessagingClientId
    • semconv messaging.client.id is generated as kMessagingClientId
    • removed code generation for messaging.client_id

See related:

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff changed the title Upgrade to semantic conventions 1.26.0 [SEMANTIC CONVENTIONS] Upgrade to semantic conventions 1.26.0 May 30, 2024
@marcalff marcalff changed the title [SEMANTIC CONVENTIONS] Upgrade to semantic conventions 1.26.0 [SEMANTIC CONVENTIONS] Upgrade to version 1.26.0 May 30, 2024
@marcalff marcalff marked this pull request as ready for review May 30, 2024 21:53
@marcalff marcalff requested a review from a team May 30, 2024 21:53
@marcalff marcalff added the pr:please-review This PR is ready for review label May 30, 2024
@codecov
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (497eaf4) to head (1ac80cc).
Report is 71 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2687      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5849     -260     
==========================================
- Hits         5322     5128     -194     
+ Misses        787      721      -66

see 58 files with indirect coverage changes

This was referenced May 30, 2024
Closed
Closed
@marcalff marcalff merged commit 4f37503 into open-telemetry:main May 31, 2024
@lalitb
Copy link
Member

lalitb commented May 31, 2024 •
edited
Loading

btw used similar workaround for otel-rust - open-telemetry/opentelemetry-rust#1851 :)

@lalitb lalitb mentioned this pull request May 31, 2024
Merged
4 tasks
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 31, 2024
@malkia
Merge pull request #41 from open-telemetry/main
34acba0 
[SEMANTIC CONVENTIONS] Upgrade to version 1.26.0 (open-telemetry#2687)
@marcalff marcalff deleted the fix_semconv_1.26 branch June 3, 2024 21:06
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcalff @lalitb