Skip to content

[CI] Upgrade to clang-format 18 #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 9 commits into from
May 29, 2024
Merged

[CI] Upgrade to clang-format 18 #2684

marcalff merged 9 commits into from
May 29, 2024

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented May 28, 2024 •
edited
Loading

Fixes #2578

Changes

Please provide a brief description of the changes here.

  • Upgraded CI to use clang-format-18 on ubuntu-24-04
  • Upgraded helper scripts
  • Applied clang-format-18 on the codebase

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.68%. Comparing base (497eaf4) to head (cdb299a).
Report is 69 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2684      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5849     -260     
==========================================
- Hits         5322     5128     -194     
+ Misses        787      721      -66
Files Coverage Δ
api/include/opentelemetry/common/kv_properties.h 98.91% <ø> (-0.06%) ⬇️
api/include/opentelemetry/common/spin_lock_mutex.h 27.78% <ø> (+2.78%) ⬆️
api/include/opentelemetry/logs/event_logger.h 90.91% <100.00%> (-1.39%) ⬇️
api/include/opentelemetry/logs/logger.h 63.89% <100.00%> (-0.69%) ⬇️
api/include/opentelemetry/logs/provider.h 100.00% <100.00%> (ø)
api/include/opentelemetry/nostd/unique_ptr.h 100.00% <100.00%> (ø)
api/include/opentelemetry/nostd/utility.h 83.34% <100.00%> (ø)
api/include/opentelemetry/trace/span.h 85.72% <ø> (+1.51%) ⬆️
api/include/opentelemetry/trace/tracer.h 100.00% <ø> (ø)
...nclude/opentelemetry/sdk/common/empty_attributes.h 100.00% <100.00%> (ø)
... and 7 more

... and 49 files with indirect coverage changes

@marcalff marcalff marked this pull request as ready for review May 28, 2024 23:30
@marcalff marcalff requested a review from a team May 28, 2024 23:30
@marcalff marcalff added the pr:please-review This PR is ready for review label May 28, 2024
@lalitb
Copy link
Member

lalitb commented May 29, 2024

We can also update Dockerfile to use the appropriate docker image so that:

./ci/run_docker.sh ./ci/do_ci.sh format

use the correct version.

@marcalff
Copy link
Member Author

marcalff commented May 29, 2024

CI failures seen in github logs:

Running kernel seems to be up-to-date.

Restarting services...
 systemctl restart chrony.service containerd.service cron.service haveged.service hv-kvp-daemon.service multipathd.service packagekit.service php8.3-fpm.service polkit.service rsyslog.service runner-provisioner.service systemd-journald.service systemd-networkd.service systemd-resolved.service systemd-udevd.service udisks2.service walinuxagent.service
Error: Process completed with exit code 143.

I assume this comes from the infrastructure, not from the opentelemetry-cpp codebase.

@marcalff marcalff merged commit c42dcca into open-telemetry:main May 29, 2024
@lalitb
Copy link
Member

lalitb commented May 29, 2024

I assume this comes from the infrastructure, not from the opentelemetry-cpp codebase.

Weird it's only coming for maintainer mode CI checks.

@marcalff marcalff deleted the upgrade_clang_format_2578 branch June 3, 2024 21:06
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] Upgrade to a newer version of clang-format

3 participants

@marcalff @lalitb @ThomsonTan