[bazel] Bump version and deps #2679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
==========================================
+ Coverage 87.12% 87.68% +0.56%
==========================================
Files 200 190 -10
Lines 6109 5851 -258
==========================================
- Hits 5322 5130 -192
+ Misses 787 721 -66 |
abseil has a lot of these now, none of them seem actionable
marcalff
reviewed
May 27, 2024
marcalff
approved these changes
May 30, 2024
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix.
To be honest, bazel just feel like a black whole to otel-cpp maintainers currently,
which makes it challenging to maintain, so this PR is all the more appreciated.
Please add comments about apple_support and rules_apple, it will go a very long way to help us.
Member
|
Don't pay attention to CI breaks, this is a general github issue. |
lalitb
reviewed
May 31, 2024
lalitb
approved these changes
Jun 5, 2024
Member
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. with nit comment on documenting the abseil requirement.
ThomsonTan
reviewed
Jun 5, 2024
Contributor
Author
|
addressed all the comments here! |
Contributor
Author
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates bazel as well as the deps that were required to be updated in order to support the newer version of bazel.
Fixes #2619