Skip to content

[BUILD] Remove the hard-coded separator in tracestate #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 1 commit into from
May 23, 2024
Merged

[BUILD] Remove the hard-coded separator in tracestate #2672

marcalff merged 1 commit into from
May 23, 2024

Conversation

@ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented May 20, 2024

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team May 20, 2024 21:59
@codecov
Copy link

codecov bot commented May 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (497eaf4) to head (74cd28e).
Report is 64 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
+ Coverage   87.12%   87.59%   +0.47%     
==========================================
  Files         200      188      -12     
  Lines        6109     5847     -262     
==========================================
- Hits         5322     5121     -201     
+ Misses        787      726      -61
Files Coverage Δ
api/include/opentelemetry/trace/trace_state.h 97.60% <100.00%> (ø)

... and 57 files with indirect coverage changes

@ThomsonTan ThomsonTan added the pr:please-review This PR is ready for review label May 21, 2024
marcalff
marcalff approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@marcalff marcalff changed the title [BUILD] Remove the hard-coded separate in tracestate [BUILD] Remove the hard-coded separator in tracestate May 23, 2024
@marcalff marcalff merged commit 78d488c into open-telemetry:main May 23, 2024
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 23, 2024
@malkia
Merge pull request #37 from open-telemetry/main
b595d65 
[BUILD] Remove the hard-coded separator in tracestate (open-telemetry#2672)
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThomsonTan @marcalff