Skip to content

[BUILD] Upgrade to opentelemetry-proto 1.3.1 #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 3 commits into from
May 16, 2024
Merged

[BUILD] Upgrade to opentelemetry-proto 1.3.1 #2669

marcalff merged 3 commits into from
May 16, 2024

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented May 15, 2024 •
edited
Loading

Contributes to #2657

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.54%. Comparing base (497eaf4) to head (587ef41).
Report is 62 commits behind head on main.

❗ Current head 587ef41 differs from pull request most recent head 23e6570. Consider uploading reports for the commit 23e6570 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
+ Coverage   87.12%   87.54%   +0.42%     
==========================================
  Files         200      188      -12     
  Lines        6109     5840     -269     
==========================================
- Hits         5322     5112     -210     
+ Misses        787      728      -59

see 55 files with indirect coverage changes

@marcalff
Copy link
Member Author

marcalff commented May 16, 2024

CI broken by:

@marcalff marcalff marked this pull request as ready for review May 16, 2024 13:22
@marcalff marcalff requested a review from a team May 16, 2024 13:22
@marcalff marcalff added the pr:please-review This PR is ready for review label May 16, 2024
lalitb
lalitb approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

@marcalff marcalff merged commit 2db27dd into open-telemetry:main May 16, 2024
@marcalff marcalff mentioned this pull request May 23, 2024
Merged
3 tasks
@marcalff marcalff deleted the upgrade_proto_1.3.1 branch June 3, 2024 21:05
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
@Pravila00 Pravila00 mentioned this pull request Jul 10, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcalff @ThomsonTan @lalitb