[BUILD] Upgrade bazel abseil from 20220623.1 to 20230802.2 #2650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcalff
changed the title
marcalff
added
issue:blocking
Member
|
Thanks, so upgrading to anything greater than abseil-cpp-20230802.2 breaks the build ? |
lalitb
approved these changes
Apr 29, 2024
Member
Author
Yes, but in a different way. It breaks because abseil type traits conflicts with std, this probably is an issue with the C++ standard used and WITH_STL. To resolve separately with #2619. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Context
Recently, the
CIin github upgraded the MacOS runners from version2.315.0to2.316.0.Before: https://github.com/actions/runner-images/blob/macOS-12/20240412.2/images/macos/macos-12-Readme.md
After: https://github.com/actions/runner-images/blob/macos-14-arm64/20240422.3/images/macos/macos-14-arm64-Readme.md
This broke the build, due to errors related to C++ traits in abseil headers.
Because the MacOS build is flagged as required, this issue actually is critical, because it prevents to merge any PR.
Changes
Please provide a brief description of the changes here.
20230802.2For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes