[SEMANTIC CONVENTIONS] Upgrade to semantic convention 1.25.0 #2633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owent
approved these changes
Apr 12, 2024
marcalff
reviewed
Apr 13, 2024
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
The code change looks ok.
Please add a CHANGELOG entry to document the breaking change, as some semantic conventions declarations moved from sdk/resource to trace: the user code will need adjustments.
lalitb
approved these changes
Apr 16, 2024
marcalff
approved these changes
Apr 16, 2024
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
Approved and merging.
Will write CHANGELOG entry as part of 1.15.0 release notes
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Apr 16, 2024
[SEMANTIC CONVENTIONS] Upgrade to semantic convention 1.25.0 (open-telemetry#2633)
marcalff
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2614 (issue)
Changes
upgrades semantic convention 1.25.0
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes