Skip to content

[SDK] DefaultLogHandler to print errors to std::cerr, add LogLevel::None #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 9 commits into from
Apr 13, 2024
Merged

[SDK] DefaultLogHandler to print errors to std::cerr, add LogLevel::None #2622

marcalff merged 9 commits into from
Apr 13, 2024
+63 −16

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Mar 28, 2024 •
edited
Loading

Fixes #2611

Changes

Please provide a brief description of the changes here.

  • Fixed the default log handler to print errors and warnings in std::cerr instead of std::cout.
  • Implemented a new LogLevel::None

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed (N/A)

@marcalff marcalff requested a review from a team March 28, 2024 23:33
owent
owent reviewed Mar 29, 2024
View reviewed changes
@marcalff marcalff changed the title [SDK] DefaultLogHandler to print to std::cerr, add LogLevel::None [SDK] DefaultLogHandler to print errors to std::cerr, add LogLevel::None Apr 4, 2024
@marcalff marcalff merged commit 78947b2 into open-telemetry:main Apr 13, 2024
@malkia malkia mentioned this pull request Apr 15, 2024
Merged
3 tasks
@BrewTestBot BrewTestBot mentioned this pull request Apr 21, 2024
Closed
@marcalff marcalff deleted the fix_otel_log_level_2611 branch June 3, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@lalitb lalitb lalitb left review comments

@owent owent owent approved these changes

+1 more reviewer

@Falmarri Falmarri Falmarri left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ThomsonTan ThomsonTan

@lalitb lalitb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable internal otel logging

5 participants

@marcalff @Falmarri @ThomsonTan @lalitb @owent