Skip to content

Conversation

@owent
Copy link
Member

@owent owent commented Mar 25, 2024

Fixes #2605

Changes

  • Do not link prometheus-cpp::util when it doesn't exist

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team March 25, 2024 06:34
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@marcalff marcalff merged commit 02e6ad2 into open-telemetry:main Mar 25, 2024
@marcalff marcalff changed the title Do not link prometheus-cpp::util when it doesn't exist [BUILD] Do not link prometheus-cpp::util when it doesn't exist Mar 25, 2024
@owent owent deleted the fixes_2605 branch June 21, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prometheus-cpp::util is not found in prometheus-cpp 1.1.0 and before. Which will make prometheus fail to build

2 participants