[EXPORTER] Add option to disable Prometheus otel_scope_name and otel_scope_version attributes #2451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwoj
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2451 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 199 199
Lines 6087 6087
=======================================
Hits 5299 5299
Misses 788 788 |
timwoj
force-pushed
the
prometheus-disable-otel-scope
branch
2 times, most recently
from
4984656 to
fe7eca7
Compare
marcalff
approved these changes
Dec 15, 2023
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the fix.
LGTM, see minor renaming.
timwoj
force-pushed
the
prometheus-disable-otel-scope
branch
from
53eafc8 to
db79d41
Compare
marcalff
changed the title
marcalff
added
the
ok-to-merge
Member
|
Thanks for the fixes. Please update this branch with the latest main changes. The auto-merge flag is enabled, this PR should merge to main once updated. |
auto-merge was automatically disabled
December 16, 2023 15:04
Head branch was pushed to by a user without write access
timwoj
force-pushed
the
prometheus-disable-otel-scope
branch
from
db79d41 to
d0b712f
Compare
Member
|
Reopen. This collides with the following spec PR, which defines the option and environment variable to use: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2442 (plus one bonus fix)
Changes
populate_otel_scopeoption to thePrometheusExporterOptionsobject defaulting to enabled, including an environment variable to control itotel_scope_nameandotel_scope_versionattributes added to instruments in Prometheus outputpopulate_target_infooption ofPrometheusExporterOptionsI opted to use (abuse) the side effect of the scope variable being null for the actual disabling of the attributes here, instead of passing the option down through the method chain to where it's used. If that's undesirable, I can switch to passing it.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes