Skip to content

[BUILD] Fix cpack broken package version#2386

Merged
marcalff merged 1 commit intoopen-telemetry:mainfrom
jafonso:package_version_fix
Oct 25, 2023
Merged

[BUILD] Fix cpack broken package version#2386
marcalff merged 1 commit intoopen-telemetry:mainfrom
jafonso:package_version_fix

Conversation

@jafonso
Copy link
Copy Markdown
Contributor

@jafonso jafonso commented Oct 25, 2023

Changes

At the moment, when I follow the instructions for generating binary packages (link), I can create a rpm with the correct name, but it has the wrong version configured (e.g. 0.1.1 instead of 1.12.0):

$ rpm -qip opentelemetry-cpp-1.12.0-centos-7-x86_64.rpm
Name        : opentelemetry-cpp
----> Version     : 0.1.1
Release     : 1
Architecture: x86_64
Install Date: (not installed)
Group       : unknown
Size        : 55377670
License     : Apache-2.0
Signature   : (none)
Source RPM  : opentelemetry-cpp-0.1.1-1.src.rpm
Build Date  : Wed Oct 25 17:31:13 2023
Build Host  : [removed]
Relocations : /usr
Vendor      : OpenTelemetry
URL         : https://opentelemetry.io/
Summary     : OpenTelemetry C++ for Linux - C++ Implementation of OpenTelemetry Specification
Description :
DESCRIPTION
===========

This is an installer created using CPack (https://cmake.org). No additional installation instructions provided.

This minor fix solves that problem:

$ rpm -qip opentelemetry-cpp-1.12.0-centos-7-x86_64.rpm
Name        : opentelemetry-cpp
----> Version     : 1.12.0
Release     : 1
Architecture: x86_64
Install Date: (not installed)
Group       : unknown
Size        : 60969267
License     : Apache-2.0
Signature   : (none)
Source RPM  : opentelemetry-cpp-1.12.0-1.src.rpm
Build Date  : Wed Oct 25 16:33:02 2023
Build Host  : [removed]
Relocations : /usr
Vendor      : OpenTelemetry
Summary     : OpenTelemetry C++ for Linux - C++ Implementation of OpenTelemetry Specification
Description :
DESCRIPTION
===========

This is an installer created using CPack (https://cmake.org). No additional installation instructions provided.

@jafonso jafonso requested a review from a team October 25, 2023 15:33
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Oct 25, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

lalitb
lalitb approved these changes Oct 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please sign for CLA for this to get merged.

@jafonso
Copy link
Copy Markdown
Contributor Author

jafonso commented Oct 25, 2023

Thanks. Please sign for CLA for this to get merged.

Thanks, I have completed this now

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 25, 2023

Codecov Report

Merging #2386 (cee6824) into main (0baf501) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2386   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         199      199           
  Lines        6030     6030           
=======================================
  Hits         5272     5272           
  Misses        758      758

@marcalff marcalff changed the title Fix cpack broken package version [BUILD] Fix cpack broken package version Oct 25, 2023
@marcalff marcalff merged commit d3a873a into open-telemetry:main Oct 25, 2023
@jafonso jafonso deleted the package_version_fix branch October 26, 2023 08:01
@Porkepix Porkepix mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jafonso @ThomsonTan @lalitb @marcalff