[SDK] Creating DoubleUpDownCounter with no matching view#2379
Merged
marcalff merged 3 commits intoopen-telemetry:mainfrom Oct 19, 2023
Merged
[SDK] Creating DoubleUpDownCounter with no matching view#2379marcalff merged 3 commits intoopen-telemetry:mainfrom
marcalff merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2379 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 199 199
Lines 6028 6028
=======================================
Hits 5270 5270
Misses 758 758
|
marcalff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2377
Changes
In case of a matching view, the SDK picks the Aggregation with correct monotonic for DoubleUpDownCounter as here. The problem was in the logic when there is no matching view, which is fixed now. Also added test for this scenario.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes