Skip to content

[BUILD] Remove WITH_REMOVE_METER_PREVIEW, use WITH_ABI_VERSION_2 instead #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 2 commits into from
Oct 16, 2023
Merged

[BUILD] Remove WITH_REMOVE_METER_PREVIEW, use WITH_ABI_VERSION_2 instead #2370

marcalff merged 2 commits into from
Oct 16, 2023

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Oct 16, 2023 •
edited
Loading

Fixes #2363

Changes

Please provide a brief description of the changes here.

  • Removed redundant option WITH_REMOVE_METER_PREVIEW, used WITH_ABI_VERSION_2

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team October 16, 2023 19:22
lalitb
lalitb approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2370 (d8f44df) into main (46e20a4) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2370      +/-   ##
==========================================
+ Coverage   87.41%   87.43%   +0.02%     
==========================================
  Files         199      199              
  Lines        6018     6018              
==========================================
+ Hits         5260     5261       +1     
+ Misses        758      757       -1
Files Coverage Δ
api/include/opentelemetry/metrics/meter_provider.h 100.00% <ø> (ø)
api/include/opentelemetry/metrics/noop.h 37.26% <ø> (ø)
sdk/src/metrics/meter_provider.cc 86.85% <ø> (ø)

... and 1 file with indirect coverage changes

@marcalff marcalff merged commit e918960 into open-telemetry:main Oct 16, 2023
@marcalff marcalff deleted the fix_remove_meter_2363 branch October 27, 2023 10:14
@Porkepix Porkepix mentioned this pull request Dec 7, 2023
Merged
@marcalff marcalff mentioned this pull request Jun 14, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove WITH_REMOVE_METER_PREVIEW, use WITH_ABI_VERSION_2 instead

2 participants

@marcalff @lalitb