[BUILD] Build break with external CMake nlohman_json package #2353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 87.41% 87.39% -0.01%
==========================================
Files 199 199
Lines 6018 6018
==========================================
- Hits 5260 5259 -1
- Misses 758 759 +1 |
Closed
lalitb
approved these changes
Oct 10, 2023
ThomsonTan
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2352
Changes
The unit test program
otlp_http_log_record_exporter_testdepends onnlohman_json.Because of this, the dependency should be made explicit in CMakeList.tst
CHANGELOG.mdupdated for non-trivial changes