Skip to content

[TEST] Expand api singleton test to cover explicit dlopen(). #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcalff merged 16 commits into from
Jul 3, 2023
Merged

[TEST] Expand api singleton test to cover explicit dlopen(). #2164

marcalff merged 16 commits into from
Jul 3, 2023

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented May 30, 2023 •
edited
Loading

Fixes # (issue)

Changes

No change in production code, unit test only.

Expand the api singleton test to cover libraries:

  • never linked with the main binary at built time
  • loaded at runtime with dlopen()

The test case added is only available when building with CMake.

When building with bazel, the test case is commented, due to an existing limitation of bazel.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team May 30, 2023 12:59
@marcalff marcalff changed the title [TEST] Expand api singleton test to cover libraries loaded with dlopen(). [WIP][TEST] Expand api singleton test to cover libraries loaded with dlopen(). May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #2164 (17b95ee) into main (42709f4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2164   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files         169      169           
  Lines        4889     4889           
=======================================
  Hits         4278     4278           
  Misses        611      611

@marcalff marcalff changed the title [WIP][TEST] Expand api singleton test to cover libraries loaded with dlopen(). [WIP][TEST] Expand api singleton test to cover explicit dlopen(). May 30, 2023
@marcalff marcalff changed the title [WIP][TEST] Expand api singleton test to cover explicit dlopen(). [TEST] Expand api singleton test to cover explicit dlopen(). May 30, 2023
@marcalff
Copy link
Member Author

marcalff commented Jun 1, 2023

Fix works for CMake.

For bazel, blocked by bazelbuild/bazel#4218

@marcalff
Copy link
Member Author

marcalff commented Jun 5, 2023

Now ready for review.

lalitb
lalitb approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay.

@marcalff marcalff merged commit ebbcd48 into open-telemetry:main Jul 3, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 14, 2023
Merged
@marcalff marcalff deleted the fix_singleton_hell branch September 5, 2023 15:14
@marcalff marcalff mentioned this pull request Feb 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb approved these changes

Assignees

@ThomsonTan ThomsonTan

@lalitb lalitb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcalff @lalitb @ThomsonTan