Add attributes for InstrumentationScope
#2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Move `MakeAttributes` from `logger.h` to `key_value_iterable_view.h` + Add attributes support for InstrumentationScope in `GetLogger()` Signed-off-by: owent <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
==========================================
+ Coverage 87.29% 87.32% +0.03%
==========================================
Files 166 166
Lines 4662 4673 +11
==========================================
+ Hits 4069 4080 +11
Misses 593 593
|
Signed-off-by: owent <[email protected]>
owent
changed the title
InstrumentationScopeInstrumentationScope
lalitb
reviewed
Feb 24, 2023
sdk/include/opentelemetry/sdk/instrumentationscope/instrumentation_scope.h
Outdated
Show resolved
Hide resolved
Signed-off-by: WenTao Ou <[email protected]>
lalitb
approved these changes
Feb 28, 2023
| * @param attributes | ||
| * @return nostd::span<const std::pair<nostd::string_view, common::AttributeValue>> | ||
| */ | ||
| inline static nostd::span<const std::pair<nostd::string_view, common::AttributeValue>> |
Member
There was a problem hiding this comment.
nit - with this cleanup, we can also remove
# include "opentelemetry/nostd/span.h"
# include "opentelemetry/nostd/type_traits.h"
from header includes, need to check if there are others too.
Member
Author
There was a problem hiding this comment.
Thanks, and the unused headers are removed now.
And #2008 is also included in this PR.
+ Populate Instrumentation Scope attributes Signed-off-by: owent <[email protected]>
lalitb
added
the
ok-to-merge
This was referenced Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1690
Fixes #1882
Fixes #2008
Should we alse add attribute for
TracerProvider::GetTracerandMeterProvider::GetMeter?Changes
InstrumentationScopeMakeAttributesfromlogger.htokey_value_iterable_view.hGetLogger()For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes